Able to use settings as context settings #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theboxer
requested changes
Nov 10, 2025
Member
theboxer
left a comment
theboxer
left a comment
There was a problem hiding this comment.
The support should be also extended into the modAI\API\Prompt\Vision endpoint
|
|
||
| public function post(ServerRequestInterface $request): void | ||
| { | ||
| $contextKey = ''; |
| $base = Settings::getTextSetting($this->modx, $field, 'base_prompt', $namespace, false); | ||
| $fieldPrompt = Settings::getTextSetting($this->modx, $field, 'prompt', $namespace); | ||
| $customOptions = Settings::getTextSetting($this->modx, $field, 'custom_options', $namespace, false); | ||
| $model = Settings::getTextSetting($this->modx, $field, 'model', $namespace, 'openai/gpt-4o-mini', $contextKey); |
Member
There was a problem hiding this comment.
Wrong arguments, instead of required you're passing model name
| $fieldPrompt = Settings::getTextSetting($this->modx, $field, 'prompt', $namespace); | ||
| $customOptions = Settings::getTextSetting($this->modx, $field, 'custom_options', $namespace, false); | ||
| $model = Settings::getTextSetting($this->modx, $field, 'model', $namespace, 'openai/gpt-4o-mini', $contextKey); | ||
| $temperature = (float)Settings::getTextSetting($this->modx, $field, 'temperature', $namespace , 0, $contextKey); |
Member
There was a problem hiding this comment.
wrong arguments, the required one
| $customOptions = Settings::getTextSetting($this->modx, $field, 'custom_options', $namespace, false); | ||
| $model = Settings::getTextSetting($this->modx, $field, 'model', $namespace, 'openai/gpt-4o-mini', $contextKey); | ||
| $temperature = (float)Settings::getTextSetting($this->modx, $field, 'temperature', $namespace , 0, $contextKey); | ||
| $maxTokens = (int)Settings::getTextSetting($this->modx, $field, 'max_tokens', $namespace, 0, $contextKey); |
Member
There was a problem hiding this comment.
wrong arguments, the required one
| $maxTokens = (int)Settings::getTextSetting($this->modx, $field, 'max_tokens', $namespace, 0, $contextKey); | ||
| $output = Settings::getTextSetting($this->modx, $field, 'base_output', $namespace, false, $contextKey); | ||
| $base = Settings::getTextSetting($this->modx, $field, 'base_prompt', $namespace, false, $contextKey); | ||
| $fieldPrompt = Settings::getTextSetting($this->modx, $field, 'prompt', $namespace, false, $contextKey); |
Member
There was a problem hiding this comment.
the prompt for field should be required, that's the whole reason for the generate button on those fields, that it'll get prompt from a system setting
| * @return string|null | ||
| */ | ||
| private static function getOption(modX $modx, string $namespace, string $field, string $area, string $setting): ?string | ||
| private static function getOption(modX $modx, string $namespace, string $field, string $area, string $setting, string $contextKey = 'web'): ?string |
Member
There was a problem hiding this comment.
Default value for $contextKey should be null
| $handler = $modx; | ||
|
|
||
| if (!empty($contextKey)) { | ||
|
|
| * @throws RequiredSettingException | ||
| */ | ||
| public static function getTextSetting(modX $modx, string $field, string $setting, string $namespace = 'modai', bool $required = true): ?string | ||
| public static function getTextSetting(modX $modx, string $field, string $setting, string $namespace = 'modai', bool $required = true, string $contextKey = ''): ?string |
Member
There was a problem hiding this comment.
default for $contextKey should be null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we can now use the modai system settings as context setting.
This helps with multi language websites to have seperate prompts for each context.